Randomized who starts the fight

Conversation 0 Commits 1 Files Changed 2

Jonathan commented

Owner

See title

Jonathan added 1 commit

a736adaafb Randomized who starts the fight

Jonathan requested review from kziolkowski

kziolkowski reviewed

scripts/CSharp/Common/Fight/FightHappening.cs

													
					            HappeningData.fighterTurn.AddAsLast(fighter);

					        }

					        if (GD.RandRange(0, 2) != 0) // 2/3 chance for vesna to start

kziolkowski commented

Owner

warum nicht 50/50?

Jonathan commented

Poster

Owner

Wirkt "fairer" für den Spieler

kziolkowski reviewed

scripts/CSharp/Common/Fight/FighterTurn.cs

													
					    /// <summary>

					    /// Sets the current one back

					    /// This is an expensive operation, because the entire data structure needs to be circled

kziolkowski commented

Owner

Danke für den Hinweis. Passiert das aktuell nur beim Kampfstart oder könnte das potenziell auch wann anders benutzt werden? Und wenn ja, ab wann würde das zu Problemen führen?

Jonathan commented

Poster

Owner

Passiert aktuell nur beim Kampfstart.
Probleme sollte das nie machen. Dafür müssten Tausende oder sogar Millionen Kämpfer aktiv sein, bevor man das performancetechnisch merkt.

kziolkowski approved these changes

Jonathan merged commit edc133749f into develop 4 weeks ago

Jonathan referenced this issue from a commit

Merge pull request 'Randomized who starts the fight' (#41) from randomise_fight_start into develop

Reviewers

kziolkowski approved these changes

The pull request has been merged as edc133749f.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Jonathan/Babushka#41

Randomized who starts the fight #41

Reviewers