Made attack selection only select alive enemies

Conversation 0 Commits 1 Files Changed 3

Jonathan commented

Owner

see title

Jonathan added 1 commit

6375383373 🐛Made attack selection only select alive enemies

Jonathan requested review from kziolkowski

kziolkowski reviewed

scripts/CSharp/Common/Fight/AllFightersVisual.cs

													
					        if (targetDetail.selectAlly)

					            _fighterVisuals

					                .Where(kv => kv.Key.IsInFormation(HappeningData.allyFighterFormation))

					                .Where(kv => !targetDetail.aliveOnly || kv.Key.IsAlive())// if aliveOnly: take where IsAlive

kziolkowski commented

Owner

Können wir für den Moment drinlassen, aber das würde ja auch verhindern, dass man irgendwann mal KO-Allies reviven kann, oder? Weil man sie nie selecten kann.

Jonathan commented

Poster

Owner

Es gibt ja schon aliveOnly. Wenn wir irgendwann nur Tote selektieren wollen, kann man noch ein deadOnly einfügen oder zu einem aliveStatus ändern

kziolkowski approved these changes

Jonathan merged commit 6deb6e29fd into develop 4 weeks ago

Jonathan referenced this issue from a commit

Merge pull request 'Made attack selection only select alive enemies' (#45) from bug/attack_dead_enemy into develop

Reviewers

kziolkowski approved these changes

The pull request has been merged as 6deb6e29fd.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Jonathan/Babushka#45

Made attack selection only select alive enemies #45

Reviewers