Jonathan

/

Babushka

feature/showcase_bugfixing_kathi #14

Merged

Jonathan merged 20 commits from feature/showcase_bugfixing_kathi into develop

kziolkowski commented

Owner

Part one of integrating bugfixes after the IGF showcase:

item interactions:
- Interaction Area 2D now works with an outline material and a label. Created a separate PR for this: http://h2996454.stratoserver.net:3000/Jonathan/Babushka/pulls/13
- added second outline color to differentiate simple interactions (yellow) from inventory item interactions (orange)
- fixed layering issues in farm outside and common room scene
- dialogic:
  - increased global font size
  - made text left-bound
  - made answer options more visible
  - deactivated animated characters in the scene during dialogues
  - removed vesna2 character and replaced it with vesna
- fixed vesna's movement sothat it looks more like walking and less like gliding

319 KiB

321 KiB

1.9 MiB

kziolkowski added 20 commits

d2c7302ab2 Fixed farming (the way it was before)

b92eb909ad Removed no longer needed print statements

486cfb5546 WIP trying to fix the last plant stage bug on repeated farming rounds

ab23d41496 Fixed ysorting on ducks and trash

5ee295256b Fixed Yeli Layering issue in indoor scene

ad16b86171 wip exchanging interaction label with outline

cfe604d3b7 set duck body scale to 1,1

730c4999d7 Extracted FightAttack Enum in the hopes of fixing errors

19e30dd0b8 Removed disclaimer reference from bootstrap

0f246825fc Added Wellbehaviour and fixed door interaction to offer outlines

18711776bb Fixed output error ERROR: Script class can only be set together with base class name

f01143e887 cleaned up dialogue structure and removed vesna2 from dialogues

e88ba2e1ef Updated interaction area setups to avoid nullrefs

279cac22ee Fixed dialogic settings

6275bea52c MAde Vesna and Yeli disappear on dialogic start

8f75b5b644 Added secondary outline mat and assigned it to inventory items

b69191e7f7 fixed pickup layering

2e21fb7e98 Made sure splash screen features logo

8e0dced918 Vesna can walk diagonally now

0008b16d48 Adjusted moving values and animations to make vesna not slide any more

Jonathan was assigned by kziolkowski

Jonathan was unassigned by kziolkowski

kziolkowski requested review from Jonathan

Jonathan approved these changes

scripts/CSharp/Common/CharacterControls/PlayerMovement.cs

													
							if (anyActionPressed)

							{

								if (currentVelocity.X != 0 && currentVelocity.Y != 0)

Jonathan commented

Owner

Never compare floating point numbers by == or !=

Maybe use instead:

if (currentVelocity.LengthSquared() > _speed * _speed)
{
    currentVelocity = currentVelocity.Normalized() * _speed;
}

Jonathan merged commit 9253a78a06 into develop 10 months ago

Jonathan referenced this issue from a commit

Merge pull request 'feature/showcase_bugfixing_kathi' (#14) from feature/showcase_bugfixing_kathi into develop

Reviewers

Jonathan approved these changes

The pull request has been merged as 9253a78a06.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Jonathan/Babushka#14